Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASP vp multiple txs #2689

Closed
wants to merge 19 commits into from
Closed

MASP vp multiple txs #2689

wants to merge 19 commits into from

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Feb 21, 2024

Describe your changes

Closes #2595.

Indicate on which release or other PRs this topic is based on

#2621

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 886 lines in your changes are missing coverage. Please review.

Comparison is base (9181fbe) 53.38% compared to head (0502eaa) 53.11%.
Report is 10 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 300 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 236 Missing ⚠️
crates/apps/src/lib/client/masp.rs 0.00% 97 Missing ⚠️
crates/apps/src/lib/cli.rs 0.00% 69 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 40 Missing ⚠️
crates/apps/src/lib/cli/client.rs 0.00% 32 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 30 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 28 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 19 Missing ⚠️
crates/apps/src/lib/client/tx.rs 0.00% 18 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
- Coverage   53.38%   53.11%   -0.28%     
==========================================
  Files         302      303       +1     
  Lines      103398   103938     +540     
==========================================
+ Hits        55203    55206       +3     
- Misses      48195    48732     +537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco
Copy link
Contributor Author

grarco commented Feb 21, 2024

Closed in favor of #2690

@grarco grarco closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple transactions from masp VP
3 participants